Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: acme DNS providers #4021

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Fix: acme DNS providers #4021

merged 2 commits into from
Oct 11, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Oct 11, 2018

What does this PR do?

Fix DNS challenges:

  • bluecat
  • cloudxns
  • dnspod
  • glesys
  • sakuracloud

Extra:

  • Add DNS Provider for Stackpath

Motivation

Fixes some bugs.

More

  • [-] Added/updated tests
  • [-] Added/updated documentation

@traefiker traefiker added this to the 1.7 milestone Oct 11, 2018
@ldez ldez added the bot/light-review decreases the number of required LGTM from 3 to 1. label Oct 11, 2018
juliens
juliens approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title Fix: acme providers Fix: acme DNS providers Oct 11, 2018
@traefiker traefiker merged commit 7eeac63 into traefik:v1.7 Oct 11, 2018
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Oct 11, 2018
@ldez ldez deleted the fix/acme-providers branch October 12, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@ldez @juliens @traefiker