Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix certificate insertion loop to keep valid certificate and ignore the bad one #4050

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Fix certificate insertion loop to keep valid certificate and ignore the bad one #4050

merged 1 commit into from
Oct 16, 2018

Conversation

jbdoumenjou
Copy link
Member

What does this PR do?

Don't fail globally but log an error on a bad certificate and append the valid certificates.

Motivation

Fixes #4010

More

  • Added/updated tests

@jbdoumenjou @nmengin
Fix error on the certificate appending loop
b22f4a4 
Co-authored-by: Nicolas Mengin <nmengin.pro@gmail.com>
@traefiker traefiker added this to the 1.7 milestone Oct 15, 2018
@ldez ldez added the kind/bug/fix a bug fix label Oct 15, 2018
juliens
juliens approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit ba99fbe into traefik:v1.7 Oct 16, 2018
@traefiker traefiker mentioned this pull request Oct 16, 2018
Closed
@jbdoumenjou jbdoumenjou deleted the hotfix/4010-append-certs-error branch October 16, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/tls kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@jbdoumenjou @juliens @mmatur @nmengin @ldez @traefiker