Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add double wildcard test #4091

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Add double wildcard test #4091

merged 1 commit into from
Oct 23, 2018

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Oct 22, 2018

What does this PR do?

Adds a test for two wildcard certs that overlap, ensuring the best one is chosen.

Motivation

Helping review #4081

Closes #4081

More

  • Added/updated tests
  • Added/updated documentation - None needed

@dtomcej dtomcej changed the title add double wildcard test Add double wildcard test Oct 22, 2018
@traefiker traefiker added this to the 1.7 milestone Oct 22, 2018
@ldez ldez added the area/tls label Oct 23, 2018
@ldez ldez force-pushed the issue-4081 branch 2 times, most recently from 73fbfc0 to 81db9ab Compare October 23, 2018 11:03
Ullaakut
Ullaakut approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@Ullaakut Ullaakut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 82b2a10 into traefik:v1.7 Oct 23, 2018
@traefiker traefiker mentioned this pull request Oct 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ullaakut Ullaakut Ullaakut approved these changes

@ldez ldez ldez approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/tls size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@dtomcej @juliens @jbdoumenjou @ldez @Ullaakut @traefiker