Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default path if nothing present #4097

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Add default path if nothing present #4097

merged 1 commit into from
Oct 25, 2018

Conversation

SantoDE
Copy link
Collaborator

@SantoDE SantoDE commented Oct 23, 2018

What does this PR do?

Adds the option to have an Ingress without Host & Path and have it not broken :)

Motivation

Fix #4076

More

  • Added/updated tests
  • [-] Added/updated documentation

Additional Notes

@SantoDE SantoDE requested a review from a team as a code owner October 23, 2018 13:28
@traefiker traefiker added this to the 1.7 milestone Oct 23, 2018
@SantoDE SantoDE force-pushed the empty_host_path branch 2 times, most recently from 87dea2b to 2d7e01f Compare October 23, 2018 13:29
dtomcej
dtomcej approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez changed the title add default path if noting present add default path if nothing present Oct 23, 2018
@ldez ldez added the kind/bug/fix a bug fix label Oct 24, 2018
ldez
ldez approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 22ee870 into traefik:v1.7 Oct 25, 2018
@traefiker traefiker mentioned this pull request Oct 25, 2018
Closed
@ldez ldez changed the title add default path if nothing present Add default path if nothing present Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@ldez ldez ldez approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
7 participants
@SantoDE @juliens @ldez @dtomcej @jbdoumenjou @mmatur @traefiker