Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marathon TLS/basic auth #468

Merged
merged 2 commits into from
Jun 22, 2016
Merged

Fix marathon TLS/basic auth #468

merged 2 commits into from
Jun 22, 2016

Conversation

emilevauge
Copy link
Member

@emilevauge emilevauge commented Jun 18, 2016

This PR fixes Marathon TLS/basic auth.
It also adds DCOS token support.

Fixes #365

Signed-off-by: Emile Vauge emile@vauge.com

@vdemeester
Copy link
Contributor

@emilevauge I think tests need updates 👼

# github.com/containous/traefik/provider

provider/marathon_test.go:115: cannot use fakeClient (type *fakeClient) as type marathon.Marathon in field value:

    *fakeClient does not implement marathon.Marathon (missing ApplicationByVersion method)

provider/marathon_test.go:199: cannot use map[string]string literal (type map[string]string) as type *map[string]string in field value

provider/marathon_test.go:218: cannot use map[string]string literal (type map[string]string) as type *map[string]string in field value

provider/marathon_test.go:237: cannot use map[string]string literal (type map[string]string) as type *map[string]string in field value

provider/marathon_test.go:256: cannot use map[string]string literal (type map[string]string) as type *map[string]string in field value

provider/marathon_test.go:275: cannot use map[string]string literal (type map[string]string) as type *map[string]string in field value

provider/marathon_test.go:295: cannot use map[string]string literal (type map[string]string) as type *map[string]string in field value

provider/marathon_test.go:314: cannot use []*marathon.HealthCheck literal (type []*marathon.HealthCheck) as type *[]marathon.HealthCheck in field value

provider/marathon_test.go:338: cannot use []*marathon.HealthCheck literal (type []*marathon.HealthCheck) as type *[]marathon.HealthCheck in field value

provider/marathon_test.go:365: cannot use []*marathon.HealthCheck literal (type []*marathon.HealthCheck) as type *[]marathon.HealthCheck in field value

provider/marathon_test.go:365: too many errors

FAIL    github.com/containous/traefik/provider [build failed]

…upport

Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
@emilevauge
Copy link
Member Author

@samber @vdemeester Finally green 🎉

@vdemeester
Copy link
Contributor

Yay 😇
LGTM 🐮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marathon Basic Auth/TLS Broken
3 participants