Fix host Docker network #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
emilevauge
force-pushed
the
fix-docker-network-host
branch
from
991a666
to
6fd8979
Compare
| @@ -270,7 +270,12 @@ func (provider *Docker) getIPAddress(container dockertypes.ContainerJSON) string | |||
| } | |||
| } | |||
| } | |||
| for _, network := range container.NetworkSettings.Networks { | |||
| for networkName, network := range container.NetworkSettings.Networks { | |||
There was a problem hiding this comment.
I'm pretty sure it's more reliable to look at container.HostConfig.NetworkMode to detect the host network mode 👼
There was a problem hiding this comment.
OK :) How to go from pretty sure to sure? ^^
What could be unreliable using container.NetworkSettings.Networks?
There was a problem hiding this comment.
Well, host is a reserved named for network (to map the networkMode host) but well…
The other thing is on versions, networkMode is guaranteed to be there since… well a while…, but NetworkSettings.Networks has been updated quite a while.
Anyway that's just a nit, backward compatibility should make it that it works ok like that for more than a while 👼
|
LGTM 🐹 |
Signed-off-by: Emile Vauge <emile@vauge.com>
emilevauge
force-pushed
the
fix-docker-network-host
branch
from
e924261
to
b1ecb1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #487
Fixes #447
Signed-off-by: Emile Vauge emile@vauge.com