Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move webui to FountainJS with Webpack #558

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Move webui to FountainJS with Webpack #558

merged 1 commit into from
Jul 27, 2016

Conversation

micaelmbagira
Copy link
Contributor

  • webui migrated to FountainJS
  • now uses Webpack instead of Bower/Wiredep
  • Some modifications in src regarding the import of modules since we use Webpack
  • FountainJS webapps require Node4+ and NPM3+

@micaelmbagira
Copy link
Contributor Author

Rebased 😉

@emilevauge
Copy link
Member

@micaelmbagira thanks :)
It seems you removed webui/readme.md, is it intended ?

@micaelmbagira
Copy link
Contributor Author

Right, it wasn't on purpose, I've just added it

@emilevauge
Copy link
Member

emilevauge commented Jul 26, 2016

There is an issue building the webui, it seems gulp is not available: https://travis-ci.org/containous/traefik/jobs/147392567#L1611 (same on my laptop)

@micaelmbagira
Copy link
Contributor Author

Yes, we should replace gulp with npm run build in Makefile and so npm will use the local gulp. Even on your laptop, you need to run npm run build if you don't want to install gulp globally

@emilevauge
Copy link
Member

OK I tried using in Makefile:

generate-webui: build-webui
    if [ ! -d "static" ]; then \
        mkdir -p static; \
        docker run --rm -v "$$PWD/static":'/src/static' traefik-webui npm run build; \
        echo 'For more informations show `webui/readme.md`' > $$PWD/static/DONT-EDIT-FILES-IN-THIS-DIRECTORY.md; \
    fi

but I got :

[11:52:25] Loading /src/webui/gulp_tasks/browsersync.js
[11:52:25] Loading /src/webui/gulp_tasks/karma.js
[11:52:26] Loading /src/webui/gulp_tasks/misc.js
[11:52:26] Loading /src/webui/gulp_tasks/webpack.js
[11:52:27] Using gulpfile /src/webui/gulpfile.js
[11:52:27] Starting 'default'...
[11:52:27] Starting 'clean'...
[11:52:27] 'clean' errored after 9.89 ms
[11:52:27] Error: Cannot delete files/folders outside the current working directory. Can be overriden with the `force` option.
    at safeCheck (/src/webui/node_modules/del/index.js:19:9)
    at /src/webui/node_modules/del/index.js:35:5
    at Array.map (native)
    at /src/webui/node_modules/del/index.js:33:28
    at run (/src/webui/node_modules/core-js/modules/es6.promise.js:87:22)
    at /src/webui/node_modules/core-js/modules/es6.promise.js:100:28
    at flush (/src/webui/node_modules/core-js/modules/_microtask.js:18:9)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)
[11:52:27] 'default' errored after 13 ms

@emilevauge
Copy link
Member

LGTM!
Great job @micaelmbagira ! Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants