fix for nil clientTLS causing issue #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jangie
force-pushed
the
fix-nil-client-tls
branch
4 times, most recently
from
dbd0522
to
9eaec8e
Compare
|
Could you try reproducing the issue in a test perhaps... might not be possible, but it would be worth a try. |
|
Sure, I'll try to figure out a good way to test for the situation and will submit a test later tonight if I can figure one out. |
jangie
force-pushed
the
fix-nil-client-tls
branch
from
9eaec8e
to
0757a75
Compare
|
@errm test has been added, but I'm a bit of a golang noob. please feel free to tear it apart if I've done something that isn't matching what you'd like to see. |
|
Thanks @jangie LGTM ping @containous/traefik |
|
hum… LGTM 🐱 |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing locally, I found that I was receiving a NPE due to this being nil. I was using the marathon provider at the time, and I believe it happened as a result of that provider asking for client TLS handling even though it hadn't been configured.