Some fixes #687
Merged
Some fixes #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
force-pushed
the
some-fixes
branch
2 times, most recently
from
bea4ff1
to
b88685d
Compare
emilevauge
force-pushed
the
some-fixes
branch
3 times, most recently
from
ffaec73
to
e82992c
Compare
|
ping @containous/traefik |
vdemeester
reviewed
Sep 21, 2016
| // JobBackOff is an exponential backoff implementation for long running jobs. | ||
| // In long running jobs, an operation() that fails after a long Duration should not increments the backoff period. | ||
| // If operation() takes more than MinJobInterval, Reset() is called in NextBackOff(). | ||
| type JobBackOff struct { |
There was a problem hiding this comment.
Hum I'm not sure about the naming of the package (and also the import we to). Shouldn't the package be job (or something like that) and this struct BackOff as an job implem' using a backoff strategie ?
And thus, the import wouldn't need to be aliased below.
There was a problem hiding this comment.
Hum, import alias would still be needed ẁith backoff.RetryNotify no?
err := backoff.RetryNotify(operation, job.NewJobBackOff(backoff.NewExponentialBackOff()), notify)
There was a problem hiding this comment.
no because you're package would be named job
There was a problem hiding this comment.
(instead of backoff currently — which is why you need to do an alias as of this PR)
emilevauge
force-pushed
the
some-fixes
branch
2 times, most recently
from
d5a1dec
to
0e88566
Compare
|
LGTM |
vdemeester
approved these changes
Sep 23, 2016
|
LGTM on rebase |
emilevauge
force-pushed
the
some-fixes
branch
from
0e88566
to
e4d8f54
Compare
emilevauge
force-pushed
the
some-fixes
branch
from
e4d8f54
to
a882a9d
Compare
ldez
added
status/3-needs-merge
and removed
status/2-needs-review
status/3-docs-review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #451