Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated link to Kubernetes.io in README.md #713

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Oct 5, 2016

Just removed a duplicated link into README. Nothing really important :-)

Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch LGTM

@emilevauge
Copy link
Member

@oscerd thanks for noticing :)
There is an issue with the travis build. Could you rebase to solve this?

@oscerd
Copy link
Contributor Author

oscerd commented Oct 6, 2016

I updated the commit date and pushed again

@oscerd
Copy link
Contributor Author

oscerd commented Oct 6, 2016

It doesn't seems to need a rebase, but maybe I'm losing something :-)

@oscerd
Copy link
Contributor Author

oscerd commented Oct 6, 2016

The problem seems to be with this

[ERROR] Failed to set version on github.com/mailgun/manners to fada45142db3f93097ca917da107aa3fad0ffcb5: Unable to update checked out version

@oscerd
Copy link
Contributor Author

oscerd commented Oct 6, 2016

Let me know if it's my fault

@emilevauge emilevauge changed the base branch from master to v1.1 October 6, 2016 15:12
@emilevauge
Copy link
Member

OK, this issue is solved on branch 1.1, can you rebase on this branch? I just changed your PR to v1.1 branch. Thanks :)

@oscerd
Copy link
Contributor Author

oscerd commented Oct 6, 2016

@emilevague, sorry for this, I was looking at master branch. Sorry :-)

@oscerd
Copy link
Contributor Author

oscerd commented Oct 6, 2016

My fault anyway :-D

@oscerd
Copy link
Contributor Author

oscerd commented Oct 7, 2016

Rebased again.

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit 1cae35f into traefik:v1.1 Oct 7, 2016
@oscerd
Copy link
Contributor Author

oscerd commented Oct 7, 2016

Thanks. It was a minor problem :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants