-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kubernetes examples #731
Conversation
it's not a good practice for the safety and it's won't work on some case with "hostNetwork: true" the best is to use service with externalIP |
Yeah, that is true @ekozan. Either that or remove the hostPort all together as it does not work as it is on |
kubernetes/kubernetes#31307 it's will be fix soon .... i hope :D |
This is great news 😄 |
Ping @errm :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made few comments. Could you also rebase your PR ? Thanks :)
@@ -944,7 +944,7 @@ Annotations can be used on containers to override default behaviour for the whol | |||
|
|||
- `traefik.frontend.rule.type: PathPrefixStrip`: override the default frontend rule type (Default: `PathPrefix`). | |||
|
|||
You can find here an example [ingress](https://raw.githubusercontent.com/containous/traefik/master/examples/k8s.ingress.yaml) and [replication controller](https://raw.githubusercontent.com/containous/traefik/master/examples/k8s.rc.yaml). | |||
You can find here an example [ingress](https://raw.githubusercontent.com/containous/traefik/master/examples/k8s/checkes-ingress.yaml) and [replication controller](https://raw.githubusercontent.com/containous/traefik/master/examples/k8s/traefik.yaml). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean cheese-ingress.yaml
right ?
@@ -16,11 +16,12 @@ spec: | |||
labels: | |||
k8s-app: traefik-ingress-lb | |||
name: traefik-ingress-lb | |||
version: v1.0.0 | |||
version: v1.0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be even better to go on v1.1.0
;)
Updated and rebased on |
/cc @containous/traefik |
Starefossen do you have an cluster with and CNI like Weave on it ? and this hack work ? Because on my cluster it's just dont work like I said |
@ekozan yes, I have a cluster where this technique is working running |
@ekozan if you joine the Træffik Slack Channel https://traefik.herokuapp.com/ I can help you debug this. Will be online for another hour. |
This PR:
hostNetwork: true
to Kubernetes Deployment. This is required in order to bind directly to host ports.