Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes examples #731

Merged
merged 4 commits into from
Oct 17, 2016
Merged

Update Kubernetes examples #731

merged 4 commits into from
Oct 17, 2016

Conversation

Starefossen
Copy link
Contributor

@Starefossen Starefossen commented Oct 12, 2016

This PR:

  • adds hostNetwork: true to Kubernetes Deployment. This is required in order to bind directly to host ports.
  • removes duplicated Kubernetes examples so we only have one source of up to date examples for Kubernetes.

@ekozan
Copy link

ekozan commented Oct 12, 2016

it's not a good practice for the safety and it's won't work on some case with "hostNetwork: true"

the best is to use service with externalIP
or hostPort on the deployment when node teams correct the actual ""bug"" with this on the cni plugins

@Starefossen
Copy link
Contributor Author

Yeah, that is true @ekozan.

Either that or remove the hostPort all together as it does not work as it is on 1.4.0.

@ekozan
Copy link

ekozan commented Oct 12, 2016

kubernetes/kubernetes#31307 it's will be fix soon .... i hope :D

@Starefossen
Copy link
Contributor Author

This is great news 😄

@emilevauge emilevauge changed the base branch from master to v1.1 October 12, 2016 20:23
@emilevauge emilevauge added this to the 1.1 milestone Oct 12, 2016
@emilevauge
Copy link
Member

Ping @errm :)

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made few comments. Could you also rebase your PR ? Thanks :)

@@ -944,7 +944,7 @@ Annotations can be used on containers to override default behaviour for the whol

- `traefik.frontend.rule.type: PathPrefixStrip`: override the default frontend rule type (Default: `PathPrefix`).

You can find here an example [ingress](https://raw.githubusercontent.com/containous/traefik/master/examples/k8s.ingress.yaml) and [replication controller](https://raw.githubusercontent.com/containous/traefik/master/examples/k8s.rc.yaml).
You can find here an example [ingress](https://raw.githubusercontent.com/containous/traefik/master/examples/k8s/checkes-ingress.yaml) and [replication controller](https://raw.githubusercontent.com/containous/traefik/master/examples/k8s/traefik.yaml).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean cheese-ingress.yaml right ?

@@ -16,11 +16,12 @@ spec:
labels:
k8s-app: traefik-ingress-lb
name: traefik-ingress-lb
version: v1.0.0
version: v1.0.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be even better to go on v1.1.0 ;)

@Starefossen
Copy link
Contributor Author

Updated and rebased on origin/v1.1 😄

@emilevauge
Copy link
Member

/cc @containous/traefik

@emilevauge emilevauge merged commit 9b765d2 into traefik:v1.1 Oct 17, 2016
@ekozan
Copy link

ekozan commented Oct 17, 2016

Starefossen do you have an cluster with and CNI like Weave on it ? and this hack work ?

Because on my cluster it's just dont work like I said $_$

@Starefossen
Copy link
Contributor Author

@ekozan yes, I have a cluster where this technique is working running kubernetes-cni and Weave on Oracle Enterprise Linux 7 set up by kubeadm.

@Starefossen
Copy link
Contributor Author

@ekozan if you joine the Træffik Slack Channel https://traefik.herokuapp.com/ I can help you debug this. Will be online for another hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants