-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom script #411
Comments
Shoutrrr is a go library, so we have no idea what the running environment is like. It also feels like a potential security issue that the consumers of the library would need to handle. |
Shoutrrr doesn't need to know the environment, the user is supposed to know what they want to call. I'll explain my context. I'm using Shoutrrr with Watchtower, and I need to know when an update is available and take some custom actions. Because I can't do that, I can't use Watchtower. I'm moving to Diun, as they support custom scripts, see: https://crazymax.dev/diun/notif/script/ Regarding security, the script would have as much privilege as the process running Shoutrrr, if that is compromised, I'd say the risk is much greater than starting a process. |
Watchtower is running inside a container with no additional binaries, so there is nothing to run your script in. No bash, no python, nothing. That's what I meant by "the environment". Diun seems to be much more suitable for your usage though, as it's main usage scenario is watching for docker image updates. |
I could volume mount what I need. |
It would be nice to have shoutrrr simply call a custom script and pass the arguments. We could extend then it as we needed.
The text was updated successfully, but these errors were encountered: