Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support injecting special characters currently blocked by Serde #2

Open
puhley opened this issue Jun 13, 2023 · 0 comments
Open

Support injecting special characters currently blocked by Serde #2

puhley opened this issue Jun 13, 2023 · 0 comments

Comments

@puhley
Copy link
Collaborator

puhley commented Jun 13, 2023

Version: Initial Release

Description:
The current Rust implementation leverages Serde for serialization. Serde will deny any attempt to serialize characters that are not supported by the JSON specification: https://github.com/serde-rs/json/blob/master/src/read.rs#L787. This is great data validation on Serde's part, but it inhibits this tool's ability to conduct certain tests. In order to emulate attacker behavior, a workflow needs to be established where this tool can create malicious manifests with those special characters.

This issue could be solved a number of ways. One approach would be to manipulate manifests after their creation but prior to the signature being applied. This approach may have the advantage of allowing more types of manipulation beyond just this issue. Another option could be to use a serialization library that doesn't include this validation step. This bug is to track the high-level requirement to solve this problem.

Expected result:
This tool should be able to generate manifests with any character injected into it.

Actual result:
This tool is currently limited by an allow list implementation with the serialization library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant