Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Error generating box hashes when the C2PA box is the first or last box #624

Closed
brogdonm opened this issue Oct 9, 2024 · 0 comments · May be fixed by #673
Closed

Bug: Error generating box hashes when the C2PA box is the first or last box #624

brogdonm opened this issue Oct 9, 2024 · 0 comments · May be fixed by #673
Labels
status: done

Comments

@brogdonm
Copy link
Contributor

brogdonm commented Oct 9, 2024

The current BoxHash::generate_box_hash_from_stream is setup to always assume there are boxes before AND after the C2PA box.

https://github.com/contentauth/c2pa-rs/blob/main/sdk/src/assertions/box_hash.rs#L240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: release contentauth/c2pa-rs
1 participant
@brogdonm