fix: stop simultaneous recursive chains #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shikaan
approved these changes
Apr 19, 2021
| @@ -25,8 +25,13 @@ class Pagination { | |||
| this.shopifyClient = await makeShopifyClient(this.sdk); | |||
| } | |||
|
|
|||
| async fetchNext(search) { | |||
| async fetchNext(search, recursing = false) { | |||
There was a problem hiding this comment.
I am not really a fan of arbitrary flags, but that might be me. What about interrupting recursion before entering the new call? So just before the return of this method (L63 in the new version, L58 of the old one)
There was a problem hiding this comment.
I'm not sure. I think that makes it more likely that we'll be returning data from a dead chain - and I think would make this change a lot more complicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the calls made in shopify can take a long time to resolve. Because of the way the pagination code is structured, this could lead to there being multiple recursive chains of calls for the function
fetchNexthappening simultaneously. Each time the function is invoked we checked whether the search term had changed, and if so, assumed that this was a new search term and that we should start fetching from scratch. If two requests became active at once, they would both repeatedly reset, as with each call it would be appear that the search term had changed.