feat: update to the latest forma and new tokens #336
Conversation
suevalov
commented
Jul 26, 2021
•
suevalov
commented
- Bumps Forma36 to the latest version
- Update all tokens values (using codemod)
There was a problem hiding this comment.
The previous naming vs current values are a bit confusing e.g: ElementMid < TextMid but overall code looks fine. I guess colorPrimary doesn't need changing?
I would manual check also on how apps look with these new values @fabe
colomolo
force-pushed
the
update-to-the-latest-forma
branch
from
50c5202 to
7877a6e
Compare
|
Checked these apps (don't have access to all of them):
|
| @@ -13,6 +13,9 @@ describe("EditorPage", () => { | |||
| beforeEach(() => { | |||
| sdk = mockProps.sdk; | |||
| sdk.entry.fields.experimentId.onValueChanged = fn => () => {}; | |||
|
|
|||
| Date.now = jest.fn(() => 100); | |||
There was a problem hiding this comment.
Is there a reason for this change? 🤔
There was a problem hiding this comment.
Tests failed due to tricky date and random number mock logic inside the Dropdown component:
https://github.com/contentful/forma-36/blob/99609176a0604fd0f6b62753cf45a246cdbb48b6/packages/forma-36-react-components/src/components/Dropdown/Dropdown.test.tsx#L11-L14
Ids are generated based on random number, so needed to stub it here too. Checked this in with @suevalov
| @@ -185,7 +185,7 @@ export default class AppConfig extends React.Component<Props, State> { | |||
| ); | |||
| } | |||
|
|
|||
| onParameterChange = (key: string, e: React.ChangeEvent<HTMLInputElement>) => { | |||
| onParameterChange = (key: string, e: React.ChangeEvent<HTMLInputElement | HTMLTextAreaElement> | React.ChangeEvent<HTMLSelectElement>) => { | |||
There was a problem hiding this comment.
Same thing here - do we support more elements? I dont see an equivalent change in HTML? I still see the Select tag
There was a problem hiding this comment.
Type error comes from TextField using onParameterChange handler:
There was a problem hiding this comment.
Good call. Maybe then removing the HTMLInputElement?
There was a problem hiding this comment.
But this types comes from forma-36 type definition:
https://github.com/contentful/forma-36/blob/master/packages/forma-36-react-components/src/components/TextField/TextField.tsx#L35
andipaetzold
dismissed
their stale review
Lock files have the correct version now
