Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate packages to f36 v4 [EXT-3592] #890

Merged
merged 43 commits into from
Apr 25, 2022
Merged

feat: Migrate packages to f36 v4 [EXT-3592] #890

merged 43 commits into from
Apr 25, 2022

Conversation

andipaetzold
Copy link
Contributor

@andipaetzold andipaetzold commented Feb 24, 2022 •
edited
Loading

Changes

  • Upgrade Forma36 -> adjust styles and implementation
  • Forma36 v4 cannot be used for snapshot tests because of changing class names -> adjust all tests
  • Upgrade testing library -> adjust all tests

There should be no visual/functionality change besides the f36 upgrade

This will be a new major version

How to test:

  • run npm link ../../packages/dam-app-base in examples/dam-app
  • run npm link ../../packages/ecommerce-app-base in examples/ecommerce-app

@andipaetzold andipaetzold self-assigned this Feb 24, 2022
@andipaetzold andipaetzold changed the title feat: Migrate packages to f36 v4 feat: Migrate packages to f36 v4 [EXT-3592] Mar 9, 2022
@andipaetzold andipaetzold marked this pull request as ready for review April 19, 2022 10:14
@andipaetzold andipaetzold requested a review from a team as a code owner April 19, 2022 10:14
@andipaetzold andipaetzold requested a review from colomolo April 20, 2022 13:08
colomolo
colomolo approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@colomolo colomolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to check all 3,5k new lines of code, but I can't see any problems with migration. Great job!

@andipaetzold
Copy link
Contributor Author

It's hard to check all 3,5k new lines of code, but I can't see any problems with migration. Great job!

I don't expect you to review lock files 😉

@andipaetzold andipaetzold requested a review from fabe April 20, 2022 15:10
@andipaetzold andipaetzold merged commit b7a2494 into master Apr 25, 2022
@andipaetzold andipaetzold deleted the packages-dep-update branch April 25, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colomolo colomolo colomolo approved these changes

@fabe fabe fabe approved these changes

Assignees

@andipaetzold andipaetzold

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andipaetzold @fabe @colomolo