Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upload cred to client [] #2465

Merged
merged 6 commits into from
Nov 12, 2024
Merged

feat: add upload cred to client [] #2465

merged 6 commits into from
Nov 12, 2024

Conversation

2wce
Copy link
Contributor

@2wce 2wce commented Nov 11, 2024

Summary

Adding types and helper method for the new upload credentials on the upload api.

Description

This is required so we have a unified way of making these calls on staging & production. An authorised user can create an upload credential which is then used to upload a file to filestack

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

When adding a new method:

  • The new method is exported through the default and plain CMA client
  • All new public types are exported from ./lib/export-types.ts
  • Added a unit test for the new method
  • Added an integration test for the new method
  • The new method is added to the documentation

@2wce 2wce marked this pull request as ready for review November 11, 2024 14:41
@2wce 2wce requested a review from a team as a code owner November 11, 2024 14:41
@2wce 2wce self-assigned this Nov 11, 2024
@2wce 2wce merged commit 3d0fca0 into master Nov 12, 2024
3 checks passed
@2wce 2wce deleted the feat/setup-upload-cred-api branch November 12, 2024 09:35
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants