Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we bump p-throttle to v5 ? #324

Closed
Techn1x opened this issue Jan 11, 2023 · 3 comments
Closed

Can we bump p-throttle to v5 ? #324

Techn1x opened this issue Jan 11, 2023 · 3 comments
Assignees
@axe312ger

Comments

@Techn1x
Copy link

Techn1x commented Jan 11, 2023 •
edited
Loading

Dependabot PR here
#221

v4 -> v5 the package is now pure ESM.

I think in theory the upgrade should just work with no other changes, but I am not sure why Jest is failing on it. I think it is an issue specific to jest
@axe312ger
Copy link
Contributor

I will make sure this plugin supports modern ESM and then upgrade our dependencies.

@axe312ger axe312ger self-assigned this Feb 19, 2024
@Techn1x
Copy link
Author

Techn1x commented Apr 19, 2024 •
edited
Loading

p-throttle v6 is out now btw

@axe312ger axe312ger mentioned this issue Jun 26, 2024
Merged
@axe312ger
Copy link
Contributor

Closing as we now rely on p-throttle v6 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axe312ger axe312ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Techn1x @axe312ger