chore: migrate to GitHub packages #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package:_shared
package:_test
package:boolean
package:checkbox
package:date
package:default-field-editors
package:dropdown
package:json
package:list
package:location
package:markdown
package:multiple-line
package:number
package:radio
package:rating
package:reference
package:rich-text
package:single-line
package:slug
package:tags
package:url
package:validation-errors
tools
labels
…ration/migrate-to-github-packages
|
Note: I had to lock the typescript version to what is currently on master (5.1.3). Running the migration scripts seems to have caused it to resolve to a newer version (5.3.3) which requires a bump of eslint package versions. The reason for this is a deprecation warning that became an error. Our eslint config setups don't seem to currently be able to handle a simple update to eslint 8, so to not spend too much time digging I fixed the version, but we should investigate more. Edit: Managed to get eslint 8 working, but storybook 7.6 doesn't work at the moment. Since it can be more involved to migrate storybook versions, that's been pinned to same version as master along with all other dev dependencies to avoid these issues in the future. |
aodhagan-cf
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.