Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rich-text): show the selected headline inside of lists #1582

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

chrishelgert
Copy link
Contributor

We always picked the first item to check if it's a headline.
Inside lists it would be deeper nested so we need a further iteration.

Copy link
Contributor

@aodhagan-cf aodhagan-cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one other test you could consider would be when you press enter, should it keep the type?

If you have a heading 1 in a list and you make a new list item, should it also be a heading 1?

@chrishelgert
Copy link
Contributor Author

chrishelgert commented Jan 22, 2024

LGTM one other test you could consider would be when you press enter, should it keep the type?

If you have a heading 1 in a list and you make a new list item, should it also be a heading 1?

That should be still the same behaviour as before - it goes back to paragraph.
Reached out to the team, maybe a nice UX improvement for the future, as we keep bold and so on but not headlines

@chrishelgert chrishelgert merged commit aca1ccf into master Jan 23, 2024
14 checks passed
@chrishelgert chrishelgert deleted the fix/headline-status-in-list branch January 23, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants