Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose InitializedEditorType in MarkdownEditor onReady #788

Open
OriginalEXE opened this issue Jul 30, 2021 · 1 comment
Open

Expose InitializedEditorType in MarkdownEditor onReady #788

OriginalEXE opened this issue Jul 30, 2021 · 1 comment
Labels
stale Used to mark when there was no activity for a set period of time

Comments

@OriginalEXE
Copy link

Hello,

Right now the the onReady prop for the MarkdownEditor is typed as Function and InitializedEditorType type is not exported from the package, so there is no way to type the argument passed to the onReady function on the consumer side.

Ideally both onReady could be more specifically typed and the InitializedEditorType type exported.

Would be happy to open a PR if that's something you are open to, but perhaps I'm missing some reason why this was not done?

Thanks
@github-actions
Copy link

github-actions bot commented Aug 6, 2022

Marking issue as stale since there was no acitivty for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Used to mark when there was no activity for a set period of time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OriginalEXE