fix: adding new property to tagged elements that are overlapped by others [TOL-2408] #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+238
to
+239
| coordinates: taggedElement.coordinates!, | ||
| isVisible: !!taggedElement.isVisible, |
There was a problem hiding this comment.
Could we fix the typings when we create the taggedElements?
There was a problem hiding this comment.
I've added a new type now
PrecaulculatedTaggedElement
This just has the stuff that you can get directly from the tagged element, so element + attributes
The the actual TaggedElement has the calculated state without any conditional properties
chrishelgert
approved these changes
Sep 20, 2024
| export const addCalculatedAttributesToTaggedElements = ( | ||
| taggedElements: PrecaulculatedTaggedElement[], | ||
| root = window.document, | ||
| ): TaggedElement[] => { |
There was a problem hiding this comment.
Suggested change
| ): TaggedElement[] => { | |
| ): PrecaulculatedTaggedElement[] => { |
There was a problem hiding this comment.
No this should use the regular one as it now has added the calculations
There was a problem hiding this comment.
I've merged for now, let me know I can follow up later on this if you disagree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking intersections of overlapping tagged elements and adding an attribute which is sent to the editor to stop rendering tagged elements which should be hidden.