Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jwt): update jwt [ZEND-3114] #133

Merged
merged 1 commit into from
Jan 23, 2023
Merged

fix(jwt): update jwt [ZEND-3114] #133

merged 1 commit into from
Jan 23, 2023

Conversation

kdamball
Copy link
Contributor

Addressing #127

@kdamball kdamball requested a review from andipaetzold January 23, 2023 11:11
@kdamball kdamball marked this pull request as draft January 23, 2023 11:12
@kdamball kdamball marked this pull request as ready for review January 23, 2023 11:14
@andipaetzold
Copy link
Contributor

chore: won't release a new version

Should we make the dependency ^8.0.0 || ^9.0.0 as it's still compatible with the old version?

@kdamball
Copy link
Contributor Author

With v8 being vulnerable, we probably should't include it

@kdamball kdamball changed the title chore(deps): update jwt [ZEND-3114] deps(jws): update jwt [ZEND-3114] Jan 23, 2023
andipaetzold
andipaetzold approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@andipaetzold andipaetzold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge as fix:

@kdamball kdamball changed the title deps(jws): update jwt [ZEND-3114] fix(jws): update jwt [ZEND-3114] Jan 23, 2023
@kdamball kdamball changed the title fix(jws): update jwt [ZEND-3114] fix(jwt): update jwt [ZEND-3114] Jan 23, 2023
@kdamball kdamball changed the base branch from master to compatibility January 23, 2023 11:37
@kdamball kdamball merged commit 4ca7baf into compatibility Jan 23, 2023
@kdamball kdamball deleted the jwt-update branch January 23, 2023 11:38
@andipaetzold andipaetzold restored the jwt-update branch January 23, 2023 11:44
andipaetzold pushed a commit that referenced this pull request Jan 23, 2023
@kdamball @andipaetzold
fix: update jsonwebtoken (#133)
fc24220
@andipaetzold andipaetzold deleted the jwt-update branch January 23, 2023 11:51
contentful-automation bot added a commit that referenced this pull request Jan 23, 2023
@contentful-automation
chore(release): 2.0.4-next.1 [skip ci]
469a9b4 
## [2.0.4-next.1](v2.0.3...v2.0.4-next.1) (2023-01-23)

### Bug Fixes

* enforce compatible node versions (v14.15+) ([#132](#132)) ([566a17e](566a17e))
* update jsonwebtoken ([#133](#133)) ([fc24220](fc24220))
contentful-automation bot added a commit that referenced this pull request Jan 23, 2023
@contentful-automation
chore(release): 2.0.4 [skip ci]
624569a 
## [2.0.4](v2.0.3...v2.0.4) (2023-01-23)

### Bug Fixes

* enforce compatible node versions (v14.15+) ([#132](#132)) ([566a17e](566a17e))
* update jsonwebtoken ([#133](#133)) ([fc24220](fc24220))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andipaetzold andipaetzold andipaetzold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdamball @andipaetzold