feat: set host from opt [] #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe remove the docs for now and we try to find a different solution for them. PRs shouldn't be so big because of docs. |
crissto
force-pushed
the
feat/add-host-opt-to-http-client
branch
from
880812e to
a4a26d5
Compare
marcolink
reviewed
Jan 25, 2023
src/keys/get-management-token.ts
Outdated
| @@ -145,7 +146,7 @@ export const getManagementToken = (privateKey: string, opts: GetManagementTokenO | |||
| } | |||
| return createGetManagementToken( | |||
| createLogger({ filename: __filename }), | |||
| createHttpClient(), | |||
| createHttpClient({ prefixUrl: opts.host }), | |||
There was a problem hiding this comment.
I think you need to provide a default value for it, or only set it if host is defined.
andipaetzold
approved these changes
Feb 13, 2023
contentful-automation bot
added a commit
that referenced
this pull request
Feb 13, 2023
# [2.1.0](v2.0.4...v2.1.0) (2023-02-13) ### Features * set host from opt [] ([#139](#139)) ([4353c2b](4353c2b))
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds the option to change the host from the opts instead of changing the
process.env.BASE_URLbeing the only way.Why?
We give the possibility to do this in other clients as https://github.com/contentful/contentful-management.js and it will enable us to use the package in a cleaner way
Risks
Defaults are left untouched, this only changes an optional override so nothing should break