Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CRN to request signature #324

Merged
merged 5 commits into from
Aug 29, 2023
Merged

feat: add CRN to request signature #324

merged 5 commits into from
Aug 29, 2023

Conversation

andipaetzold
Copy link
Contributor

@andipaetzold andipaetzold commented Aug 23, 2023

Add option crn when signing a request. A new header x-contentful-crn is added.

CRN is optional as this would otherwise be a breaking change.

@andipaetzold andipaetzold self-assigned this Aug 23, 2023
@andipaetzold andipaetzold requested a review from a team as a code owner August 23, 2023 09:55
@andipaetzold andipaetzold requested a review from kdamball August 25, 2023 10:26
@andipaetzold andipaetzold changed the title feat: add crn to signature feat: add CRN Aug 25, 2023
@andipaetzold andipaetzold requested a review from a team August 28, 2023 13:39
Copy link
Contributor

@kdamball kdamball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have missed it but where do we add it to the list of headers we used to sign the request?

@andipaetzold andipaetzold changed the title feat: add CRN feat: add CRN to request signature Aug 29, 2023
@andipaetzold andipaetzold merged commit 01e9d09 into master Aug 29, 2023
@andipaetzold andipaetzold deleted the EXT-4657-add-crn branch August 29, 2023 08:47
contentful-automation bot added a commit that referenced this pull request Aug 29, 2023
# [2.5.0](v2.4.0...v2.5.0) (2023-08-29)

### Features

* add CRN to request signature ([#324](#324)) ([01e9d09](01e9d09))
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants