-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update delivery function handler interface #327
Conversation
Can you update the PR title? "PH discussion" is not suitable for a public npm package changelog ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will also need a change the template code, right?
query: string | ||
isIntrospectionQuery: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be part of Field mapping too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if I'm following. This boolean is used to indicate wether the query
being sent for this event is an introspection query. An app can use this to easily overwrite where the schema is loaded from, for instance by loading it from the file system instead of passing the introspection query along to the 3rd party GraphQL API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we adjust the graphQLQueryArgument
of GraphQLFieldTypeMapping
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GraphQLFieldTypeMappingResponse
should be the following:
export type GraphQLFieldTypeMappingResponse = {
namespace: string
fields: GraphQLFieldTypeMapping[]
}
# [2.4.0](v2.3.0...v2.4.0) (2023-08-28) ### Features * update delivery function handler interface ([#327](#327)) ([c31c30b](c31c30b))
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
In the PH on Tuesday we discussed the following changes
isIntrospectionQuery
boolean to thegraphql.query
event.GraphQLQueryArgument
to be aRecord<string, string>
to allow for multi-argumentGraphQLQueryField
calls. The record key would be the argument name, the key value a JSON Pointer (not set in stone, we might use a different string format) that points to the JSON property that needs to be extracted from the field value and provided as the argument value.