Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update AppActionCallContext type to reflect cmaHost #351

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

jsdalton
Copy link
Member

Purpose

Hosted app actions include a cmaHost context value, which is used to instantiate a CMA client in the correct region. The typing for AppActionCallContext was not updated at the time, so the value isn't accessible in a type safe manner inside the HAA handler.

Approach

  • Add the value to the type. It's intentionally not specified as optional, which might be a smarter choice if HAAs had a larger adoption. Since they are internal only for now, I believe it's safe to assume that all HAAs have been updated and do include the cmaHost

@jsdalton jsdalton merged commit 1c6a623 into master Sep 21, 2023
2 checks passed
@jsdalton jsdalton deleted the feature/add-cmahost-to-appactioncallcontext branch September 21, 2023 14:00
contentful-automation bot added a commit that referenced this pull request Sep 21, 2023
# [2.6.0](v2.5.2...v2.6.0) (2023-09-21)

### Features

* update AppActionCallContext type to reflect cmaHost ([#351](#351)) ([1c6a623](1c6a623))
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants