Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include spaceId as part of cacheKey #43

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

jensbodal
Copy link
Contributor

@jensbodal jensbodal commented Mar 24, 2022

I'm currently unable to use the cache because I am making requests against multiple spaces. Not sure if there is a reason spaceId wasn't included in the cacheKey but this would solve that issue for me.

@jensbodal jensbodal requested a review from a team as a code owner March 24, 2022 22:14
Copy link
Contributor

@shikaan shikaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for the contribution :)

@shikaan shikaan enabled auto-merge (squash) March 25, 2022 08:21
@shikaan shikaan disabled auto-merge March 25, 2022 08:23
@shikaan shikaan merged commit 92fc4c5 into contentful:master Mar 25, 2022
ghost pushed a commit that referenced this pull request Mar 25, 2022
## [2.0.2](v2.0.1...v2.0.2) (2022-03-25)

### Bug Fixes

* include spaceId as part of cacheKey ([#43](#43)) ([92fc4c5](92fc4c5))
@ghost
Copy link

ghost commented Mar 25, 2022

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants