Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert of second image corrupts sixel graphics #1049

Open
Yaraslaut opened this issue Feb 23, 2023 · 7 comments
Open

Insert of second image corrupts sixel graphics #1049

Yaraslaut opened this issue Feb 23, 2023 · 7 comments
Labels
bug Something isn't working frontend: OpenGL Contour OpenGL target frontend Contour Terminal Emulator (GUI frontend) high priority High Priority Item

Comments

@Yaraslaut
Copy link
Member

Yaraslaut commented Feb 23, 2023

Contour Terminal version

Contour Terminal Emulator 0.3.11-master-cd0aa937

Installer source

Github: source code cloned

Operating System

RHEL

Architecture

x86-64

Other Software

julia

Steps to reproduce

2023-02-25_09-01-12.mp4

Expected Behavior

No response

Actual Behavior

sixel rendering is broken

Additional notes

To reproduce this behavior size of the terminal in pixels must exceed 1080p

figure
lines

@Yaraslaut Yaraslaut added bug Something isn't working frontend Contour Terminal Emulator (GUI frontend) labels Feb 23, 2023
@Yaraslaut Yaraslaut changed the title Scroll corupts sixel graphics Scroll corrupts sixel graphics Feb 25, 2023
@christianparpart
Copy link
Member

I am looking at this from my phone, sorry for this. Is the problem that at the end of the scroll, the background image is shining through?

@christianparpart
Copy link
Member

I wonder if this is only happening on qml branch or also on master. 🤔

@Yaraslaut
Copy link
Member Author

I wonder if this is only happening on qml branch or also on master. thinking

No, I am seeing same behaviour on current master as well Contour Terminal Emulator 0.3.11-master-99d6e65a

@christianparpart
Copy link
Member

Ok thx. This was just a hunch.

@Yaraslaut
Copy link
Member Author

I am looking at this from my phone, sorry for this. Is the problem that at the end of the scroll, the background image is shining through?

The problem is that after i insert second image first becomes corrupted and i see this:
image

@Yaraslaut Yaraslaut changed the title Scroll corrupts sixel graphics Insert of second image corrupts sixel graphics Feb 28, 2023
@whisperity whisperity added this to the 0.3.12 milestone Apr 10, 2023
@christianparpart christianparpart added the frontend: OpenGL Contour OpenGL target label Jul 25, 2023
@Yaraslaut
Copy link
Member Author

Can be reproduced with one image, example julia code
f = Figure(resolution=(2000,1100)); ax = Axis(f[1,1]); lines!(ax,rand(100)); f

@christianparpart christianparpart modified the milestones: 0.3.x, 0.4.0 Oct 15, 2023
@christianparpart christianparpart modified the milestones: 0.4.0, 0.4.1 Dec 19, 2023
@christianparpart christianparpart modified the milestones: 0.4.1, 0.4.2 Jan 1, 2024
@christianparpart christianparpart added the high priority High Priority Item label Feb 2, 2024
@christianparpart christianparpart removed this from the 0.4.2 milestone Feb 2, 2024
@christianparpart
Copy link
Member

We figured out that #1458 is only a interim workaround but not an ultimate fix.

What should be done to close this ticket is to probably have a atlas texture size with the dimension of the current screen this window is living in.

  • if the window is moved to another screen (or the physical screen size is changed), then the texture atlas needs to be re-allocated
  • if the font size is changed only, then the texture atlas itself only needs to be re-addressed and re-initialized but not re-created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend: OpenGL Contour OpenGL target frontend Contour Terminal Emulator (GUI frontend) high priority High Priority Item
Projects
None yet
Development

No branches or pull requests

3 participants