Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DECSTBM and DECSLRM doesn't work when used to reset margins. #1164

Closed
Utkarsh-khambra opened this issue Aug 14, 2023 · 3 comments · Fixed by #1165
Closed

DECSTBM and DECSLRM doesn't work when used to reset margins. #1164

Utkarsh-khambra opened this issue Aug 14, 2023 · 3 comments · Fixed by #1165
Assignees
Labels
bug Something isn't working VT: Backend Virtual Terminal Backend (libterminal API)

Comments

@Utkarsh-khambra
Copy link
Collaborator

Contour Terminal version

Contour Terminal Emulator 0.3.13-master-7172b40d

Installer source

Github: source code cloned

Operating System

Fedora 38

Architecture

x86-64

Other Software

No response

Steps to reproduce

Set some margins first by running printf '\033[1;20r' and then reset margins by running printf '\033[r'.

Expected Behavior

After reset margin is run, contour should set margins to pagesize.

Actual Behavior

Contour doesn't reset margins and keeps the original margins that were given in previous DECSTBM invocation.

Additional notes

No response

@Utkarsh-khambra Utkarsh-khambra added bug Something isn't working VT: Backend Virtual Terminal Backend (libterminal API) labels Aug 14, 2023
@Utkarsh-khambra Utkarsh-khambra self-assigned this Aug 14, 2023
@christianparpart
Copy link
Member

christianparpart commented Aug 14, 2023

oh wow. how did you find that out? how did that bug end up in here? 🤔

EDIT: This is a case that really wants a test case added, once fixed. :)

@Utkarsh-khambra
Copy link
Collaborator Author

Utkarsh-khambra commented Aug 14, 2023

I was testing one of j4james' script and found that contour doesn't work as expected and margin reset was the reason.

@Utkarsh-khambra Utkarsh-khambra changed the title DECSTBM doesn't work when used to reset margins. DECSTBM and DECSLRM doesn't work when used to reset margins. Aug 14, 2023
@Utkarsh-khambra
Copy link
Collaborator Author

Same behavior exists in DECSLRM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants