Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File links not correctly decoded #1199

Closed
kevincox opened this issue Sep 13, 2023 · 2 comments · Fixed by #1200
Closed

File links not correctly decoded #1199

kevincox opened this issue Sep 13, 2023 · 2 comments · Fixed by #1200
Assignees
Labels
bug Something isn't working good first issue Good for newcomers VT: Backend Virtual Terminal Backend (libterminal API)

Comments

@kevincox
Copy link

Contour Terminal version

Contour Terminal Emulator 0.3.1-2022-05-01

Installer source

something else (please specify below)

Operating System

nixos-unstable

Architecture

x86-64

Other Software

No response

Steps to reproduce

% echo foo >'some file'
% ls --hyperlink=auto some\ file
'some file'

Then CTRL+Click the link.

Expected Behavior

The file opens in my text editor.

Actual Behavior

Nothing happens and there is a log message.

gio: file:///tmp/some%2520file: Error when getting information for file “/tmp/some%20file”: No such file or directory

Additional notes

No response

@kevincox kevincox added the bug Something isn't working label Sep 13, 2023
@christianparpart
Copy link
Member

Hello @kevincox,

many thanks for using Contour, and sorry for such a basic bug.

We need to URL-decode the passed value. Good catch.

EDIT: Contour Terminal Emulator 0.3.1-2022-05-01 I just noticed you are on NixOS and using an older package. We are currently on 0.3.12 as latest stable release. It might totally be still the case that we're having that bug there not fixed yet, too.

@Yaraslaut @Utkarsh-khambra NB: It might make sense to have that fixed on the 0.3.x branch as well as on master branch, so we can release a bugfix only 0.3 release.

@christianparpart christianparpart added good first issue Good for newcomers VT: Backend Virtual Terminal Backend (libterminal API) labels Sep 13, 2023
@Utkarsh-khambra
Copy link
Collaborator

I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants