Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS/X emoji size too small (due to HighDPI screens) #1215

Closed
christianparpart opened this issue Sep 23, 2023 · 8 comments
Closed

OS/X emoji size too small (due to HighDPI screens) #1215

christianparpart opened this issue Sep 23, 2023 · 8 comments
Assignees
Labels
bug Something isn't working fonts font rasterization and text shaping API and platform implementations platform: macOS topics that directly address macOS platform
Milestone

Comments

@christianparpart
Copy link
Member

seems like we are taking the DPI into account when loading the colored emoji font face in the open_shaper implementation.

@christianparpart christianparpart added bug Something isn't working fonts font rasterization and text shaping API and platform implementations platform: macOS topics that directly address macOS platform labels Sep 23, 2023
@christianparpart christianparpart self-assigned this Sep 23, 2023
@christianparpart christianparpart added this to the 0.4.0 milestone Sep 23, 2023
@Yaraslaut
Copy link
Member

Was it fixed in #1216 ?

@christianparpart
Copy link
Member Author

@Yaraslaut oh yes, you were right, i forgot to close it. thanks. :)

@erf
Copy link

erf commented Dec 19, 2023

Seems like the emojis are still small in the latest release

@christianparpart
Copy link
Member Author

Oh interesting. Many thanks for your interest, @erf.

image

This is how it is for me on latest version. I wonder what might have caused this for you to still be small. Hmmm... Would you mind sharing a little bit more info? I might be able to direct you to some logging hints tomorrow (too tired now) :)

@erf
Copy link

erf commented Dec 19, 2023

Here is a screenshot. It only seem to happen on an external monitor using a m1 macbook.

Screenshot 2023-12-20 at 00 18 46

If i'm on my internal montor it seem ok - but notice the heart emojis does only take up a single col width .. i've enabled mode 2027

Screenshot 2023-12-20 at 00 28 57

@christianparpart
Copy link
Member Author

Hi,

image So this is how it looks like on my M1. It should work (tm). I think it may of course be a system installation deviation between your M1 and my M1. Do you use a custom emoji font (anywhere)? Would you mind sharing your contour.yml config (the font configuration part at least)?

On the DPI issue that you're facing on an external monitor, I think we may need a drop-out ticket, that specifically addresses that issue. I am not having an external display next to me, but I will check ASAP as well. Many thanks for reporting (and sorry for the inconveniences :) )

@erf
Copy link

erf commented Dec 20, 2023

Hey, i just used the default config file. The heart issue seem to be in my editor (but also in vim, nvim), but if i cat the file it seem ok ... untill i drag the mouse and select that line .. very weird . i made a screen recording:

Screen.Recording.2023-12-20.at.21.09.45.mov

@christianparpart
Copy link
Member Author

Yeah, this one we'll be tracking in #1375. Many thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fonts font rasterization and text shaping API and platform implementations platform: macOS topics that directly address macOS platform
Projects
None yet
Development

No branches or pull requests

3 participants