Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncated % symbols #1262

Closed
cqexbesd opened this issue Oct 12, 2023 · 7 comments
Closed

Truncated % symbols #1262

cqexbesd opened this issue Oct 12, 2023 · 7 comments
Labels
blocker:office Bug reported by my colleges, and hence should be fixed ASAP. :) blocker release-blocking action item bug Something isn't working high priority High Priority Item VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library VT: renderer

Comments

@cqexbesd
Copy link
Contributor

Contour Terminal version

0.4.0-master-616315cc

Installer source

Github: source code cloned

Operating System

Arch Linux as of approx a week ago

Architecture

x86-64

Other Software

No response

Steps to reproduce

Type %

Expected Behavior

No response

Actual Behavior

image

The truncation occurs when using the SF Mono or LiberationMono font.

Additional notes

No response
@cqexbesd cqexbesd added the bug Something isn't working label Oct 12, 2023
@christianparpart
Copy link
Member

@Yaraslaut didn't we recently work on texture atlas wrt vertical bar? that smells related.

@christianparpart christianparpart added VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library blocker release-blocking action item VT: renderer blocker:office Bug reported by my colleges, and hence should be fixed ASAP. :) labels Oct 12, 2023
@christianparpart christianparpart added this to the 0.4.0 milestone Oct 12, 2023
@Yaraslaut
Copy link
Member

we did, #1022 issue was LCD rendering, this looks more like font fallback fault for me

@Yaraslaut
Copy link
Member

Yaraslaut commented Oct 13, 2023 •
edited
Loading

I can not reproduce it, so it seems this is font fallback. This is LiberationMono
image

@christianparpart
Copy link
Member

IIRC @cqexbesd is running a really small font size at only 96dpi. This is also why is underline at small font sizes looks so creepy. I can look at it once feeling less sick and back in the office, so I can investigate with him together at his desk :)

@christianparpart
Copy link
Member

I can not reproduce it, so it seems this is font fallback. This is LiberationMono

I think this requires a small enough font to be reproducible.

@christianparpart christianparpart modified the milestones: 0.4.0, 0.4.1 Dec 19, 2023
@christianparpart christianparpart modified the milestones: 0.4.1, 0.4.2 Jan 1, 2024
@christianparpart christianparpart added the high priority High Priority Item label Feb 2, 2024
@christianparpart christianparpart removed this from the 0.4.2 milestone Feb 2, 2024
@Yaraslaut
Copy link
Member

I tried to reproduce this with small font (down to 5 pt) and still can not reproduce this behavior, @cqexbesd if you still have this bug, output of contour debug "font.render,vt.rasterizer,font.textshaping" can give us some hints

@cqexbesd
Copy link
Contributor Author

I just updated to the latest master and I can't reproduce it anymore either so I think it has been fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker:office Bug reported by my colleges, and hence should be fixed ASAP. :) blocker release-blocking action item bug Something isn't working high priority High Priority Item VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library VT: renderer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@christianparpart @cqexbesd @Yaraslaut