Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control, Shift + Comma #1588

Open
appomsk opened this issue Aug 15, 2024 · 1 comment
Open

Control, Shift + Comma #1588

appomsk opened this issue Aug 15, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@appomsk
Copy link

appomsk commented Aug 15, 2024

Contour Terminal version

0.4.3

Installer source

AUR repository

Operating System

Manjaro

Architecture

x86-64

Other Software

No response

Steps to reproduce

Press <C-S-,>

Expected Behavior

The configuration file opens in a default editor.

Actual Behavior

Nothing happens.

Additional notes

By default in contour.yml the action OpenConfiguration binded to [Control Shift] Comma, but it doesn't work. I can open the configuration file, but only on alternative layout (ru), where the comma is in another place. When I launch neovim in contour and press <C-v><C-S-,> then Neovim insert <C-S-lt>. So I suppose that it is impossible to insert <C-S-,> at all (on the standard english qwerty layout).

@appomsk appomsk added the bug Something isn't working label Aug 15, 2024
@Yaraslaut
Copy link
Member

Hi @appomsk, thanks for the bug report, i can repro it, basically the issue is with os handling of Shift+Comma, when i press Shift+Comma i get < character
and this is what contour receive from OS
Sending Shift|Control "<" Press.

One of the ways to resolve it, is to change keybind to something else by default, for example
- { mods: [Control], key: Comma, action: OpenConfiguration }

To fix this issue we have to find a list of shortcuts ( I suppose os specific) and untangle them during input handling, such that we understand that Shift+Comma will appear as < in pty.input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants