Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VT Parser to use char instead char32_t #471

Closed
christianparpart opened this issue Oct 22, 2021 · 1 comment
Closed

Change VT Parser to use char instead char32_t #471

christianparpart opened this issue Oct 22, 2021 · 1 comment
Labels
performance Performance issues or improvements
Milestone

Comments

@christianparpart
Copy link
Member

christianparpart commented Oct 22, 2021

Use char instead of char32_t as input.

Later then in Ground state and OSC (/DCS) should decode UTF-8 into UTF-32 payloads when UTF-8 is to be expected.

That should definitely improve performance. But how much?

When doing this, the new Cell struct could just store a char instead of char32_t and filor any higher codepoints defer to CellExtra. saves 3 bytes for the standard case.

@christianparpart christianparpart added the performance Performance issues or improvements label Oct 22, 2021
@christianparpart christianparpart mentioned this issue Oct 22, 2021
18 tasks
@christianparpart christianparpart added this to the 0.3.0 milestone Oct 23, 2021
@christianparpart
Copy link
Member Author

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements
Projects
None yet
Development

No branches or pull requests

1 participant