Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When spawned with a directory, interpret it as the starting cwd #629

Closed
whisperity opened this issue Mar 26, 2022 · 3 comments · Fixed by #1545
Closed

When spawned with a directory, interpret it as the starting cwd #629

whisperity opened this issue Mar 26, 2022 · 3 comments · Fixed by #1545
Labels
crash(-like) Bug that results in severe state corruption, lock-ups with recovery, or outright termination enhancement New feature or request feature-request User requested features frontend Contour Terminal Emulator (GUI frontend) good first issue Good for newcomers platform: linux topics that directly address Linux platform (any distro)

Comments

@whisperity
Copy link
Member

When Contour is started from a desktop integration (e.g. right click -> open with -> contour), unfortunately the integration only fires contour [... directory path ...]. This causes contour to crash because a directory cannot be started as a program image.

The solution would either be:

  1. Implement desktop integrations that work with the right-click menu. This might be problematic due to the absolute plethora of desktop environments to support.
  2. "Hotwire" Contour so if it is spawned with only a directory as the first argument, interpret it as "start with the default profile but spawn the configured shell in that directory".

For example, Konsole does not crash (at least...), but is also rather buggy: when opening, from Dolphin, Konsole in ~/foo/bar as the "Open with..." action, it spawns the default shell in ~/foo.

@whisperity whisperity added enhancement New feature or request frontend Contour Terminal Emulator (GUI frontend) stability platform: linux topics that directly address Linux platform (any distro) feature-request User requested features labels Mar 26, 2022
@uspasojevic96
Copy link
Member

Oh this is interesting, I can look into this one later, the whole topic of .desktop files is convoluted

@christianparpart
Copy link
Member

This could be fixed by being a little bit more smart and check the file modes to decide if it is supposed to be the CWD or shell.

@christianparpart
Copy link
Member

@uspasojevic96 Mind, I broke the master branch (RGB colors) last night, I will fix that tonight. Sorry.

@christianparpart christianparpart added the good first issue Good for newcomers label Jun 21, 2022
@whisperity whisperity added crash(-like) Bug that results in severe state corruption, lock-ups with recovery, or outright termination and removed stability labels Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash(-like) Bug that results in severe state corruption, lock-ups with recovery, or outright termination enhancement New feature or request feature-request User requested features frontend Contour Terminal Emulator (GUI frontend) good first issue Good for newcomers platform: linux topics that directly address Linux platform (any distro)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants