Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Qt 6 on all platforms #955

Closed
7 of 10 tasks
christianparpart opened this issue Dec 28, 2022 · 6 comments
Closed
7 of 10 tasks

Migrate to Qt 6 on all platforms #955

christianparpart opened this issue Dec 28, 2022 · 6 comments
Labels
code health Code quality related topics. frontend Contour Terminal Emulator (GUI frontend) platform: FreeBSD FreeBSD platform specific platform: linux topics that directly address Linux platform (any distro) platform: macOS topics that directly address macOS platform platform: windows topics that directly address Windows platform
Milestone

Comments

@christianparpart
Copy link
Member

christianparpart commented Dec 28, 2022

Motivation behind? Supporting multiple major Qt versions seems almost impossible. And with the move to QML on the frontend side, it's basically not possible at all.

The idea is to only use Qt 6 only, have all references to Qt 5 completely removed, and then have a much easier time when working on the QML port again.

The only challenge here is the older Linux distributions that either don't have native Qt 6 package or aren't even supported by Qt at all (Ubuntu 18.04!).

Checklist

  • OS/X
  • Windows
  • FreeBSD
  • Fedora Linux
  • Arch Linux
  • Ubuntu 22.04
  • Ubuntu 20.04
  • RHEL
  • AppImage (using Ubuntu 18.04 as base?)
  • Have all support of Qt 5 completely removed.
@christianparpart christianparpart added code health Code quality related topics. platform: macOS topics that directly address macOS platform platform: linux topics that directly address Linux platform (any distro) platform: windows topics that directly address Windows platform platform: FreeBSD FreeBSD platform specific labels Dec 28, 2022
@christianparpart christianparpart added this to the 2023-1 milestone Dec 28, 2022
@christianparpart christianparpart added the frontend Contour Terminal Emulator (GUI frontend) label Dec 28, 2022
@Yaraslaut
Copy link
Member

I have a need to use RHEL on one of the systems which does not allow me to install packages for qt6, we need some sort of solution for this.

Quote @whisperity
I'd prefer if qt6 was not embedded into the contour package but available as a separate package...
contour-qt-libs or something

@christianparpart
Copy link
Member Author

yeah, the next release (apart from regular CI is doing) should definitely be Qt5 based. We can adapt release workflow to reflect that. we have enough useful changes in already that are useful to users. :)

Regular CI builds I would leave to be Qt6 based to have as broad test coverage of that as possible - while not removing the backwards compat from the code explictly.

@Yaraslaut
Copy link
Member

So i think that we are good in this regard, we just need to update AppImage ? (@christianparpart ) and then we can close this issue since we are supporting both Qt versions and can drop Qt5 whenever we want

@christianparpart
Copy link
Member Author

I think we should keep the appimage build instructions on CI updated, even though it's currently not executed or uploaded - because there were issues with AppImage, but they should be fixed eventually. So yeah, since actually ALL but AppImage are on Qt6 on CI build/release now, I think we can even close it right now (or after having ensured that AppImage would build using Qt6 as well). :)

@Yaraslaut
Copy link
Member

I think we should keep the appimage build instructions on CI updated, even though it's currently not executed or uploaded - because there were issues with AppImage, but they should be fixed eventually. So yeah, since actually ALL but AppImage are on Qt6 on CI build/release now, I think we can even close it right now (or after having ensured that AppImage would build using Qt6 as well). :)

Great :)
I will update AppImage build, and if everything will be smooth we can advice people to use it if some distro is not supported

@Yaraslaut
Copy link
Member

We can compile contour with Qt6 or Qt5 supoprt, difference exist only in qml part only, and we can remove Qt5 support if needed, thus closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Code quality related topics. frontend Contour Terminal Emulator (GUI frontend) platform: FreeBSD FreeBSD platform specific platform: linux topics that directly address Linux platform (any distro) platform: macOS topics that directly address macOS platform platform: windows topics that directly address Windows platform
Projects
None yet
Development

No branches or pull requests

2 participants