Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding remarks from my side #7

Open
jerch opened this issue Dec 30, 2020 · 1 comment
Open

adding remarks from my side #7

jerch opened this issue Dec 30, 2020 · 1 comment

Comments

@jerch
Copy link

jerch commented Dec 30, 2020

Hi Christian, just got through your draft. Thats a really good start, but as you might have guessed I have several remarks both regarding the technical aspects as well as for the writing. Now I wonder how to start/contribute my thoughts here?

Several options come to my mind:

  1. open individual issues for the technical aspects to be dicussed before writing things down?
  2. comment inline in the tex file?
  3. comment/review with a c&p PR with github's own tooling?

What would you prefer? I would tend to 1. and 3. (as 2. would clutter the tex file), but it is up to you.

@christianparpart
Copy link
Member

christianparpart commented Dec 30, 2020

Hey @jerch

I strongly opt for number 1 too. Also, we can have a call (Hangouts, Discord, ...) to clear thoughts straight out, and then create/comment-to tickets for documentation or as a form of todo items. (this is how we often do communication in our EF team, to retain openess).

EDIT: p.s.: forgot to mention, I didn't work on the draft last days due to xmas/health related duties. I will slowly increase my work speed though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants