Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConsoleExtension doesn't support Nette\DI\Statement #67

Closed
silen-z opened this issue Mar 28, 2022 · 1 comment
Closed

ConsoleExtension doesn't support Nette\DI\Statement #67

silen-z opened this issue Mar 28, 2022 · 1 comment

Comments

@silen-z
Copy link

silen-z commented Mar 28, 2022

When using global functions in NEON config like: not(%debugMode%) they get created by DI as Nette\DI\Statement but here ConsoleExtension is casting them to bool which silently fails and evaulates to true regardless of the statement value

Version: 0.5.0
@silen-z silen-z changed the title ConsoleExtension doesn't suport Nette\DI\Statement ConsoleExtension doesn't support Nette\DI\Statement Mar 28, 2022
@f3l1x
Copy link
Member

f3l1x commented Dec 16, 2022

Good catch. Can you prepare PR? Some test would be excellent.

@f3l1x f3l1x closed this as completed in 2c719a4 Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@f3l1x @silen-z