Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PhpStan L2 errors #15

Open
2 tasks
trejjam opened this issue Jan 10, 2021 · 0 comments
Open
2 tasks

Fix PhpStan L2 errors #15

trejjam opened this issue Jan 10, 2021 · 0 comments
Labels
help wanted

Comments

@trejjam
Copy link
Member

trejjam commented Jan 10, 2021

The project is based on the official library design, which has major design issues. Such as dynamic property access. Overused static instantiating.

  • Remove @phpstan-ignore-line from code, fix design issue
  • Update PhpStan level int Makefile::phpstan, fix founded issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trejjam