-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix t0, tf variable #38
Conversation
@jbcaillau Please review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽 @ocots looks like the two points below from #15 (comment) are addressed:
- the standard behaviour is (i) to forbid (= throw an exception) passing a variable to a
Fixed
problem, (ii) to force passing a variable to aNonFixed = Variable
problem- two exceptions to (ii): for a dim
$1$ variable equal either tot0
ortf
, allow not to givet0
ortf
when calling a flow
@ocots final thoughts: do we agree that calling a flow is the only case when default arguments (here If yes, please merge 🤞🏾 |
I think yes. Note that when calling the flow, we could integrate until a time smaller than |
@ocots Ouh, very good point 👍🏽. Do we agree that the current behaviour is that On top of that, need to document this (-> new issue). |
We agree. Note that if there are both variables. It is intended that the variable is in order the initial time and then the final. Not the converse.
|
No description provided.