Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix t0, tf variable #38

Merged
merged 3 commits into from
Aug 6, 2024
Merged

fix t0, tf variable #38

merged 3 commits into from
Aug 6, 2024

Conversation

ocots
Copy link
Member

@ocots ocots commented Aug 6, 2024

No description provided.

@ocots ocots linked an issue Aug 6, 2024 that may be closed by this pull request
@ocots ocots requested a review from jbcaillau August 6, 2024 09:33
@ocots
Copy link
Member Author

ocots commented Aug 6, 2024

@jbcaillau Please review and merge.

@ocots ocots marked this pull request as draft August 6, 2024 11:53
@ocots ocots marked this pull request as ready for review August 6, 2024 12:00
Copy link
Member

@jbcaillau jbcaillau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 @ocots looks like the two points below from #15 (comment) are addressed:

  • the standard behaviour is (i) to forbid (= throw an exception) passing a variable to a Fixed problem, (ii) to force passing a variable to a NonFixed = Variable problem
  • two exceptions to (ii): for a dim $1$ variable equal either to t0 or tf, allow not to give t0 or tf when calling a flow

@jbcaillau
Copy link
Member

@ocots final thoughts: do we agree that calling a flow is the only case when default arguments (here t0 and tf) may also be variable, hence creating a (functional but bizarre) duplication?

If yes, please merge 🤞🏾

@ocots
Copy link
Member Author

ocots commented Aug 6, 2024

@ocots final thoughts: do we agree that calling a flow is the only case when default arguments (here t0 and tf) may also be variable, hence creating a (functional but bizarre) duplication?

If yes, please merge 🤞🏾

I think yes. Note that when calling the flow, we could integrate until a time smaller than tf.

@ocots ocots merged commit ba0c63d into main Aug 6, 2024
2 checks passed
@ocots ocots deleted the 15-flow-with-variables-nonfixed-ocp branch August 6, 2024 13:54
@jbcaillau
Copy link
Member

@ocots final thoughts: do we agree that calling a flow is the only case when default arguments (here t0 and tf) may also be variable, hence creating a (functional but bizarre) duplication?
If yes, please merge 🤞🏾

I think yes. Note that when calling the flow, we could integrate until a time smaller than tf.

@ocots Ouh, very good point 👍🏽. Do we agree that the current behaviour is that f(t0, x0, p0, t1) with the final time being the only variable (similar case for initial time or both times variable) sets the variable to t1?

On top of that, need to document this (-> new issue).

@ocots
Copy link
Member Author

ocots commented Aug 6, 2024

@ocots final thoughts: do we agree that calling a flow is the only case when default arguments (here t0 and tf) may also be variable, hence creating a (functional but bizarre) duplication?
If yes, please merge 🤞🏾

I think yes. Note that when calling the flow, we could integrate until a time smaller than tf.

@ocots Ouh, very good point 👍🏽. Do we agree that the current behaviour is that f(t0, x0, p0, t1) with the final time being the only variable (similar case for initial time or both times variable) sets the variable to t1?

We agree. Note that if there are both variables. It is intended that the variable is in order the initial time and then the final. Not the converse.

On top of that, need to document this (-> new issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow with variables (NonFixed ocp)
2 participants