-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types #21
Comments
Since I don't think everyone wants to put |
I’d welcome a PR! |
Hi @controversial, I think adding mypy to CI is a good idea, but how should I do that? I have no experience with Travis CI at all (I don't even see it running), but I can set up pre-commit or GitHub Actions if that's needed. (I'm assuming that's what you use, since there's a .travis.yml file) |
Also, is python 2 (and python 3.6) support still required? The code could be updated to only support non-EOL versions, and it would mean we could type annotations instead of outdated comments. |
I’m more than willing to drop support for EOL versions; I wrote this library a long time ago when Python 2/3.6 was still relevant! |
Also, adding mypy to a Github Action is definitely a good idea; when I wrote this library Github Actions didn’t exist so Travis was a much more natural choice, but I wouldn’t choose it again today |
Hi, thanks for the package! It would be great if type-hints could be added so this package can be used with mypy. Thanks!
The text was updated successfully, but these errors were encountered: