Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I've had to revert to 17.8.1 #3912

Closed
damienbutt opened this issue Feb 13, 2024 · 2 comments
Closed

I've had to revert to 17.8.1 #3912

damienbutt opened this issue Feb 13, 2024 · 2 comments

Comments

@damienbutt
Copy link

damienbutt commented Feb 13, 2024

I've had to revert to 17.8.1.

I've always used a .commitlintrc.json for my config.

{
    "extends": ["@commitlint/config-conventional"]
}

Executing commitlint via a commit-msg hook using Husky.

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

pnpm commitlint --edit $1

On 17.8.1, this works.

But on ^18, it breaks.

✖   Please add rules to your `commitlint.config.js`
    - Getting started guide: https://commitlint.js.org/#/?id=getting-started
    - Example config: https://github.com/conventional-changelog/commitlint/blob/master/%40commitlint/config-conventional/src/index.ts [empty-rules]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Running it from the CLI produces the same error.

echo "chore: bump deps" | pnpm commitlint
✖   Please add rules to your `commitlint.config.js`
    - Getting started guide: https://commitlint.js.org/#/?id=getting-started
    - Example config: https://github.com/conventional-changelog/commitlint/blob/master/%40commitlint/config-conventional/src/index.ts [empty-rules]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Originally posted by @damienbutt in #3909 (comment)

@damienbutt damienbutt changed the title I've had to revert to 17.8.1. I've had to revert to 17.8.1 Feb 13, 2024
@damienbutt
Copy link
Author

Result of --print-config:

{
	extends: [ '@commitlint/config-conventional' ],
	formatter: 'C:\\Users\\DamienButt\\Projects\\projectname\\node_modules\\.pnpm\\@commitlint+format@18.6.1\\node_modules\\@commitlint\\format\\lib\\index.js',
	parserPreset: undefined,
	ignores: undefined,
	defaultIgnores: undefined,
	plugins: {},
	rules: {},
	helpUrl: 'https://github.com/conventional-changelog/commitlint/#what-is-commitlint',
	prompt: {}
}

@escapedcat
Copy link
Member

Solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants