-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GitHub Enterprise Edition #3
Comments
I only copied the code from npm/repo. Do you think it's their issue? |
Sorry for the lack of information. Well, I am not sure if it is their issue, please help me out.
The issue I see is that a typical ghe installation url looks like that protocol://github.hostname.ext and Lastly conventional-changelog-core won't get package owner information either. This impact the implementation of conventional-github-releaser/issues/11 which is about enabling ghe. The immediate solution was use another package as a fallback but really it would be better if we solve it closer to the issue ( here or in npm/hosted-git-info ) Thanks |
I think it should be added at npm/hosted-git-info
Who said that? |
No one said, I am judging by the current implementation I didn't see the issue, good to know it is already open. |
|
@thiagofelix Would you be kind enough to send a PR of GHE tests? Thanks a lot. |
Sure. |
One reference implementation:
https://github.com/bahmutov/parse-github-repo-url
The text was updated successfully, but these errors were encountered: