Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub Enterprise Edition #3

Closed
thiagofelix opened this issue Apr 8, 2016 · 7 comments
Closed

Support GitHub Enterprise Edition #3

thiagofelix opened this issue Apr 8, 2016 · 7 comments

Comments

@thiagofelix
Copy link
Contributor

One reference implementation:
https://github.com/bahmutov/parse-github-repo-url

@stevemao
Copy link
Member

stevemao commented Apr 8, 2016

If you find your normalized repository is not correct, It's most likely normalize-package-data or hosted-git-info's problem. Please try to triage the problem before you open an issue here.

I only copied the code from npm/repo. Do you think it's their issue?

@thiagofelix
Copy link
Contributor Author

Sorry for the lack of information.

Well, I am not sure if it is their issue, please help me out.

The issue I see is that a typical ghe installation url looks like that protocol://github.hostname.ext and get-pkg-repo won't be able to get the user out of it.

Lastly conventional-changelog-core won't get package owner information either.

This impact the implementation of conventional-github-releaser/issues/11 which is about enabling ghe.

The immediate solution was use another package as a fallback but really it would be better if we solve it closer to the issue ( here or in npm/hosted-git-info )

Thanks

@stevemao
Copy link
Member

stevemao commented Apr 8, 2016

I think it should be added at npm/hosted-git-info

npm/hosted-git-info Is supposed to extract fields like user and project, but they don't really care about ghe

Who said that?
npm/hosted-git-info#11

@thiagofelix
Copy link
Contributor Author

No one said, I am judging by the current implementation

I didn't see the issue, good to know it is already open.
It's been 5 months already, could we do something here and remove it later when they start supporting it?

@stevemao
Copy link
Member

stevemao commented Apr 8, 2016

@bahmutov/parse-github-repo-url looks pretty solid. Maybe we could depend on that for unknown hosts.

@stevemao
Copy link
Member

stevemao commented Apr 8, 2016

@thiagofelix Would you be kind enough to send a PR of GHE tests? Thanks a lot.

@thiagofelix
Copy link
Contributor Author

Sure.

@thiagofelix thiagofelix changed the title Support Github Enterprise Support GitHub Enterprise Edition Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants