Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prerelease lifecycle script hook (closes #217) #234

Merged
merged 1 commit into from
May 21, 2018
Merged

feat: add prerelease lifecycle script hook (closes #217) #234

merged 1 commit into from
May 21, 2018

Conversation

dmfay
Copy link
Collaborator

@dmfay dmfay commented Feb 22, 2018

It took me a while to get around to it, but here's an implementation of a pre-everything script hook that won't affect behavior further into the process.

@coveralls
Copy link

coveralls commented Feb 22, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 272e2fd on dmfay:prerelease into 9a99607 on conventional-changelog:master.

@dmfay
Copy link
Collaborator Author

dmfay commented May 12, 2018

hey @bcoe -- any chance of this making it in sometime soon? :)

@bcoe
Copy link
Member

bcoe commented May 21, 2018

@dmfay I apologize for the slow turn around ... 2018 has been a bad year for OSS for me.

Refresh me, wouldn't attaching an event to prebump be equivalent to prerelease? What are the advantages of this; I suppose the fact that returning a version # doesn't have an effect on releaseAs?

@dmfay
Copy link
Collaborator Author

dmfay commented May 21, 2018

No worries, these things happen. There's more information in the original issue but you've got the gist of it: any and all output from prebump is parsed for a version number, which makes it difficult to execute anything that produces its own output.

@bcoe bcoe merged commit ba4e7f6 into conventional-changelog:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants