Maybe we should replace archived chadweimer/iron-star-rating with chadweimer/mwc-star-rating?

[saas786]

Every time I try to install npm packages in wp-theme-lib I have to face this issue.

Plus we maybe able to drop our fork and use upstream as is.

Ref: #92 (comment)

[anoblet]

It looks like we would need to override the template for mwc-star-rating. In order to do so, we would need the author to migrate to the lit package. I have filed an issue: chadweimer/mwc-star-rating#2

[saas786]

It looks like we would need to override the template for mwc-star-rating.

Why we need to override the template?

[anoblet]

I believe this template needs to be overridden in order to display vaadin:star.

https://github.com/chadweimer/mwc-star-rating/blob/b3843159a267cbe3d1be0378b769360c84dc4048/src/MwcStarRating.ts#L74-L80

[saas786]

I believe this template needs to be overridden in order to display vaadin:star.

chadweimer/mwc-star-rating@b384315/src/MwcStarRating.ts#L74-L80

If we file a PR, only than I believe plugin author might opt for lit.

As I see mwc-star-rating uses mwc-icon which is based on v^0.22.0,
ref: https://github.com/chadweimer/mwc-star-rating/blob/b3843159a267cbe3d1be0378b769360c84dc4048/package.json#L21

which also relies on lit-element

ref: https://github.com/material-components/material-web/blob/v0.22.1/packages/icon/mwc-icon.ts#L6

Though latest version uses lit
ref: https://github.com/material-components/material-web/blob/master/icon/lib/icon.ts#L7

@anoblet

Possible to run size check?

1. With current star rating (might be able to check it when doing #2, size reduction might suggest size diff)
2. With https://github.com/chadweimer/mwc-star-rating
3. With #2 but if used latest @material/mwc-icon: 0.27.0

I believe #3 will be the lightest, but as we still need to replace its icon <mwc-icon> with <vaadin:star> and is it worth using it?
Are we also doing any additional logics for this star implementation? Or just replacing the icon?

[anoblet]

I filed a PR which migrates to lit (chadweimer/mwc-star-rating#3). mwc-star-rating uses lit-html^1.3.0 which has conflicts when using more than one version of html. lit-html@^2.0.0 got rid of the requirement of having to dedupe those instances.

I have tested extending mwc-star-rating after migrating to lit, and I believe as long as we are able to override the template and the styles to vaadin-icon, we should be good to go.

[saas786]

Re-arrange devDependencies as they were before PR, as it shows un-necessary diff.

---

---

You also need to update @material/mwc-icon to v0.27.0

So we have lit version of mwc-icon too.

ref: https://github.com/material-components/material-web/releases/tag/v0.27.0

[anoblet]

@saas786

I cleaned up package.json and upgraded @material/mwc-icon.

[anoblet]

I created a PR which copies chadweimer/mwc-star-rating: #228

[lkraav]

This should be closed by #228 @anoblet? Please add "fix" / "close" verbs to commit messages in the future.