Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP4 file autoplays when playing props is set to false #14

Closed
clementoriol opened this issue Dec 17, 2015 · 2 comments
Closed

MP4 file autoplays when playing props is set to false #14

clementoriol opened this issue Dec 17, 2015 · 2 comments

Comments

@clementoriol
Copy link

Hi,
Thanks for the player, it looks promising.

There's an issue with mp4 files, they autoplay even if playing={false} is passed as a prop.

It's related with the play() call in players/Base.js componentDidMount.
It seems required to init some players (Youtube, SoundCloud...) since they're initialized in the play method. Maybe moving the initalization part in a separate method, and calling this in componentDidMount could avoid this issue.

@cookpete
Copy link
Owner

Hi @clementoriol, good spot!

This will be fixed once #13 is merged, as all the mounting/playing logic is being changed there. I'll merge it soon.

@cookpete
Copy link
Owner

Fixed in 0.3.0

@mgw-sbex mgw-sbex mentioned this issue Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants