Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when removing file based video during onProgress function #463

Closed
zzh8829 opened this issue Aug 9, 2018 · 2 comments
Closed

Error when removing file based video during onProgress function #463

zzh8829 opened this issue Aug 9, 2018 · 2 comments

Comments

@zzh8829
Copy link
Contributor

zzh8829 commented Aug 9, 2018

If we remove a video after an onProgress call is queued, a strange null pointer error will happen.
The null error happens at Player.getCurrentTime in the progress callback. The FilePlayer.getCurrentTime call might fail because FilePlayer.player is already removed from Dom and there is no null check inside of FilePlayer.

@cookpete
Copy link
Owner

How exactly are you causing this to happen?

The real solution here would be to unmount your player correctly to prevent any further progress callbacks from firing. If you are removing nodes from the DOM outside of the React rendering lifecycle you are asking for errors like this.

@cookpete
Copy link
Owner

Should be fixed in 1.6.5 which includes #465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants