-
Notifications
You must be signed in to change notification settings - Fork 1
/
Copy path106774.c
35 lines (32 loc) · 950 Bytes
/
106774.c
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
#include <stdbool.h>
void t (bool a, int i, float e, double f)
{
// Boolean literal comparisons
if (a == true) // better: if (a)
return;
if (a == false) // better: if (!a)
return;
if (a != true) // better: if (!a)
return;
if (a != false) // better: if (a)
return;
// also reversed to be sure
if (true == a) // better: if (a)
return;
if (false != a) // better: if (a)
return;
// Integer comparisons to Boolean literals
if (i == true) // better: if (i == 1)
return;
if (i == false) // better: if (i == 0) or: if (!i)
return;
if (i != true) // better: if (i != 1)
return;
if (i != false) // better: if (i != 0) or: if (i)
return;
// Floating-point comparisons to Boolean literals
if (e == true) // very strange at all, if meant so, then better: if (e == 1.0f)
return;
if (f == false) // very strange at all, if meant so, then better: if (f == 0.0)
return;
}